Page MenuHomePhabricator
Differential D5588

added glow effect behind modals
ClosedPublic
Actions

Authored by • manan on Nov 9 2022, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:17 AM
Unknown Object (File)
Tue, Dec 17, 8:17 AM
Unknown Object (File)
Tue, Dec 17, 8:17 AM
Unknown Object (File)
Tue, Dec 17, 8:17 AM
Unknown Object (File)
Tue, Dec 17, 8:17 AM
Unknown Object (File)
Tue, Dec 17, 8:13 AM
Unknown Object (File)
Sat, Nov 30, 12:50 AM
Unknown Object (File)
Thu, Nov 21, 5:15 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
ginsu
atul
• jon
Commits
rCOMM626fb77c224a: added glow effect behind modals
Summary

glow effect adds contrast between modals and background.

Test Plan

Checked different modals in app, all seem to show a glow.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• manan created this revision.Nov 9 2022, 1:45 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 9 2022, 1:45 PM
• manan added a comment.Nov 9 2022, 1:46 PM

simulator_screenshot_4AFD6BCE-1A14-4221-BD01-734400B61D58.png (2×1 px, 151 KB)

Here is a screenshot of what the glow looks like.

Harbormaster completed remote builds in B13342: Diff 18294.Nov 9 2022, 2:00 PM
• manan requested review of this revision.Nov 9 2022, 2:00 PM
atul requested changes to this revision.EditedNov 9 2022, 2:07 PM

Hm, looks like it might be hard to get the glow to look right. Can we instead copy what we're doing in native/chat/settings/color-selector-modal.react.js:

borderColor: 'modalForegroundBorder',
borderWidth: 2,

and then remove the redundant style from the ColorSelectorModal component .

This revision now requires changes to proceed.Nov 9 2022, 2:07 PM
• manan updated this revision to Diff 18305.Nov 9 2022, 10:02 PM

copied what is done in native/chat/settings/color-selector-modal.react.js

Herald added a reviewer: • jon. · View Herald TranscriptNov 9 2022, 10:02 PM
• manan updated this revision to Diff 18306.Nov 9 2022, 10:06 PM

attempting to remove changes from un-rebased pull

• manan updated this revision to Diff 18307.Nov 9 2022, 10:10 PM

update

• manan added a comment.Nov 9 2022, 10:11 PM

simulator_screenshot_7D6C51A7-89F5-4E15-B07F-31F52801838B.png (2×1 px, 141 KB)

Here's what the glow looks like now

Harbormaster completed remote builds in B13350: Diff 18305.Nov 9 2022, 10:16 PM
Harbormaster completed remote builds in B13351: Diff 18306.Nov 9 2022, 10:19 PM
Harbormaster completed remote builds in B13352: Diff 18307.Nov 9 2022, 10:23 PM
atul accepted this revision.Nov 10 2022, 5:54 AM
This revision is now accepted and ready to land.Nov 10 2022, 5:54 AM
• manan closed this revision.Nov 10 2022, 8:44 AM
mananmanchanda <mananmanchanda@mananmanchandas-MacBook-Air.local> added a commit: rCOMM626fb77c224a: added glow effect behind modals.Nov 10 2022, 8:44 AM

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
2 lines
components/
2 lines

Diff 18307

View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/components/modal.react.js

Loading...