Page MenuHomePhorge
Feed Search

Nov 10 2022

manan closed D5588: added glow effect behind modals.
Nov 10 2022, 4:44 PM
manan added a comment to D5588: added glow effect behind modals.

Here's what the glow looks like now

Nov 10 2022, 6:11 AM
manan updated the diff for D5588: added glow effect behind modals.

update

Nov 10 2022, 6:10 AM
manan updated the diff for D5588: added glow effect behind modals.

attempting to remove changes from un-rebased pull

Nov 10 2022, 6:06 AM
manan updated the diff for D5588: added glow effect behind modals.

copied what is done in native/chat/settings/color-selector-modal.react.js

Nov 10 2022, 6:02 AM

Nov 9 2022

manan requested review of D5588: added glow effect behind modals.
Nov 9 2022, 10:00 PM

Nov 2 2022

manan closed D5516: added no-var rule to root level eslint.

Landed

Nov 2 2022, 10:54 PM
manan added inline comments to D5516: added no-var rule to root level eslint.
Nov 2 2022, 6:06 PM
manan updated the diff for D5516: added no-var rule to root level eslint.

rule changed from number to string for readability

Nov 2 2022, 6:03 PM

Nov 1 2022

manan requested review of D5516: added no-var rule to root level eslint.
Nov 1 2022, 6:33 PM

Oct 31 2022

manan added a comment to D5483: added tests to check spoiler regex extracted values.

Landed changes.

Oct 31 2022, 5:36 AM

Oct 27 2022

manan updated the diff for D5483: added tests to check spoiler regex extracted values.
  1. Updating D5483: added tests to check spoiler regex extracted values #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
Oct 27 2022, 3:42 PM

Oct 26 2022

manan requested review of D5483: added tests to check spoiler regex extracted values.
Oct 26 2022, 2:22 AM

Oct 20 2022

manan added a comment to D5358: Added tests for spoiler regex.

So I was basically wondering if we can test whether the RegEx matches what we are actually looking for. So for example, if we are doing something like expect(||hello||).toMatch(spoilerRegex), is there a way to test whether the RegEx is extracting out the "spoiler text", in this case hello?

Oct 20 2022, 8:48 PM
manan abandoned D5447: more descriptive it statements, moved the RegEx text to a comment.

Amended changes to the original diff.

Oct 20 2022, 8:46 PM
manan updated the diff for D5358: Added tests for spoiler regex.

Addressed Rohan's feedback

Oct 20 2022, 8:44 PM
manan requested review of D5447: more descriptive it statements, moved the RegEx text to a comment.
Oct 20 2022, 7:26 PM
manan added a comment to D5358: Added tests for spoiler regex.

Hi @rohan, thank you for your review. To follow up on your points:
1: I've changed the it statements to be more descriptive.
2/3: I'm a bit confused on what you mean by "to actually test the match so we can see if we are matching what is expected" - could you please clarify?
4: I was getting a eslint/prettier problem when I tried to include the actual RegEx in the it statement, so I moved it to a comment. Is this okay?

Oct 20 2022, 7:20 PM

Oct 13 2022

manan requested review of D5358: Added tests for spoiler regex.
Oct 13 2022, 2:32 AM

Oct 1 2022

ashoat renamed manan.
Oct 1 2022, 10:46 AM