HomePhabricator
Diffusion Comm 03122bd87293

[identity] validate origins provided through env var

Description

[identity] validate origins provided through env var

Summary:
quick follow up to ENG-6926. the HeaderValue::from_str function takes pretty much any ascii string, but we should validate these strings first to make sure we have the right format in terraform, where we set the value of ALLOW_ORIGIN_LIST

we already use the url crate in shared/backup_client and services/commtest

Test Plan: unit tests, tested that other schemes like ftp and missing ports don't work on staging

Reviewers: will, bartek

Reviewed By: bartek

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D11250

Details

Provenance
varunAuthored on Mar 5 2024, 2:30 PM
Reviewer
bartek
Differential Revision
D11250: [identity] validate origins provided through env var
Parents
rCOMM37e15109c0cf: [backup service] Revoke log blob holders
Branches
Unknown
Tags
Unknown