HomePhabricator
Diffusion Comm 053761a8d64f

[CommCoreModule] update `setDeviceID` to return JSI Promise instead of value

Description

[CommCoreModule] update setDeviceID to return JSI Promise instead of value

Summary:
context: ENG-2184

Use JSI promise to await operation execution instead of scheduling operation and returning result immediately.

Test Plan:

  1. Build app
  2. Logout
  3. Log returned value and check in the database if the value was set correctly

Reviewers: marcin, jon, inka, atul, tomek

Reviewed By: marcin, tomek

Subscribers: ashoat, tomek, atul, abosh

Differential Revision: https://phab.comm.dev/D5574

Details

Provenance
kamilAuthored on Nov 7 2022, 8:58 AM
Reviewer
marcin
Differential Revision
D5574: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value
Parents
rCOMM24dec60ecf51: [native] fix `getDeviceID` return type
Branches
Unknown
Tags
Unknown