[CommCoreModule] update `setDeviceID` to return JSI Promise instead of value
ClosedPublic
Actions

Authored by kamil on Nov 9 2022, 10:35 AM.

Details

Reviewers

marcin
• jon
inka
atul
tomek

Commits

rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value

Summary

context: ENG-2184

Use JSI promise to await operation execution instead of scheduling operation and returning result immediately.

Test Plan

Build app
Logout
Log returned value and check in the database if the value was set correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2022, 10:35 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 9 2022, 10:36 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

kamil edited the summary of this revision. (Show Details)Nov 9 2022, 10:42 AM

kamil edited the test plan for this revision. (Show Details)

kamil added reviewers: inka, atul.

Harbormaster completed remote builds in B13304: Diff 18252.Nov 9 2022, 10:48 AM

kamil added a child revision: D5576: [native] introduce atomic flag that indicates clearing database process will execute.Nov 9 2022, 11:39 AM

kamil published this revision for review.Nov 9 2022, 1:29 PM

marcin accepted this revision.Nov 10 2022, 12:14 PM

marcin added a reviewer: tomek.

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1003 ↗	(On Diff #18252)	I think `deviceIDGenerationError` suits better here.

rename error to deviceIDGenerationError

Harbormaster completed remote builds in B13358: Diff 18315.Nov 10 2022, 3:23 PM

rebase

Harbormaster completed remote builds in B13398: Diff 18373.Nov 11 2022, 1:24 PM

tomek accepted this revision.Nov 14 2022, 4:50 PM

This revision is now accepted and ready to land.Nov 14 2022, 4:50 PM

Closed by commit rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value. · Explain WhyNov 15 2022, 2:20 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

43 lines

Diff 18430

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] update `setDeviceID` to return JSI Promise instead of valueClosedPublicActions