Page MenuHomePhabricator
Differential D5574

[CommCoreModule] update `setDeviceID` to return JSI Promise instead of value
ClosedPublic
Actions

Authored by kamil on Nov 9 2022, 2:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 9:28 PM
Unknown Object (File)
Wed, Sep 11, 2:34 AM
Unknown Object (File)
Wed, Sep 11, 2:34 AM
Unknown Object (File)
Wed, Sep 11, 2:34 AM
Unknown Object (File)
Wed, Sep 11, 2:34 AM
Unknown Object (File)
Wed, Sep 11, 2:32 AM
Unknown Object (File)
Wed, Sep 11, 2:28 AM
Unknown Object (File)
Aug 18 2024, 2:20 AM
View All 81 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
marcin
• jon
inka
atul
tomek
Commits
rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value
Summary

context: ENG-2184

Use JSI promise to await operation execution instead of scheduling operation and returning result immediately.

Test Plan
  1. Build app
  2. Logout
  3. Log returned value and check in the database if the value was set correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2022, 2:35 AM
kamil held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptNov 9 2022, 2:36 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
kamil edited the summary of this revision. (Show Details)Nov 9 2022, 2:42 AM
kamil edited the test plan for this revision. (Show Details)
kamil added reviewers: inka, atul.
Harbormaster completed remote builds in B13304: Diff 18252.Nov 9 2022, 2:48 AM
kamil added a child revision: D5576: [native] introduce atomic flag that indicates clearing database process will execute.Nov 9 2022, 3:39 AM
kamil published this revision for review.Nov 9 2022, 5:29 AM
marcin accepted this revision.Nov 10 2022, 4:14 AM
marcin added a reviewer: tomek.
marcin added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1003 ↗(On Diff #18252)

I think deviceIDGenerationError suits better here.

kamil updated this revision to Diff 18315.Nov 10 2022, 7:09 AM

rename error to deviceIDGenerationError

Harbormaster completed remote builds in B13358: Diff 18315.Nov 10 2022, 7:23 AM
kamil updated this revision to Diff 18373.Nov 11 2022, 5:10 AM

rebase

Harbormaster completed remote builds in B13398: Diff 18373.Nov 11 2022, 5:24 AM
tomek accepted this revision.Nov 14 2022, 8:50 AM
This revision is now accepted and ready to land.Nov 14 2022, 8:50 AM
Closed by commit rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value (authored by kamil). · Explain WhyNov 15 2022, 6:20 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM053761a8d64f: [CommCoreModule] update `setDeviceID` to return JSI Promise instead of value.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
43 lines

Diff 18430

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...