[lib] Don't delete pending messages during session recovery
Summary:
Noticed that the pending messages in my test plan would get erased on LOG_IN_SUCCESS during session recovery. This diff makes sure we don't lose those pending messages.
NOTE: I wanted to check if the logged-in user has changed, but we can't make it until ENG-6126 is complete. That said, this should be a redundant check.
Depends on D10695
Test Plan:
I tested this stack using the following procedure:
- I tested primarily on native
- I compiled a dev build and deployed it to an iOS simulator
- I created a brand new account on my local keyserver using the iOS app
- I ran Redux dev tools: cd native && yarn redux-devtools
- I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
- I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
- I killed the app
- I deleted all of the test user’s cookie
- I then opened the app again and navigated to a chat and sent two messages
- By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
- On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes
Reviewers: tomek, inka, atul
Reviewed By: tomek
Differential Revision: https://phab.comm.dev/D10696