Page MenuHomePhabricator

[lib] Don't delete pending messages during session recovery
ClosedPublic

Authored by ashoat on Jan 18 2024, 12:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Sun, Oct 13, 11:49 PM
Unknown Object (File)
Sun, Oct 13, 11:49 PM
Unknown Object (File)
Sun, Oct 13, 11:49 PM
Unknown Object (File)
Sun, Oct 13, 11:47 PM
Unknown Object (File)
Sep 21 2024, 3:44 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Subscribers
None

Details

Summary

Noticed that the pending messages in my test plan would get erased on LOG_IN_SUCCESS during session recovery. This diff makes sure we don't lose those pending messages.

NOTE: I wanted to check if the logged-in user has changed, but we can't make it until ENG-6126 is complete. That said, this should be a redundant check.

Depends on D10695

Test Plan

I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
lib/reducers/message-reducer.js
747 ↗(On Diff #35767)

If we want to keep this log, we should make it more descriptive. But probably we don't need it.

This revision is now accepted and ready to land.Jan 18 2024, 6:57 AM
lib/reducers/message-reducer.js
747 ↗(On Diff #35767)

Oops, that was a mistake left over from testing! Thanks for pointing it out

Remove console.log and use a couple shorthands