Page MenuHomePhabricator

[lib] Track session recovery on a per-keyserver basis
ClosedPublic

Authored by ashoat on Jan 17 2024, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 4:59 PM
Unknown Object (File)
Tue, Oct 22, 4:59 PM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Sun, Oct 13, 11:47 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Unknown Object (File)
Sep 5 2024, 11:52 PM
Unknown Object (File)
Sep 5 2024, 11:52 PM
Subscribers
None

Details

Summary

The currentlyWaitingForNewCookie and serverEndpointCallsWaitingForNewCookie constants are global, which poses a problem. If a single keyserver returns a session invalidation to the client, then while the client is attempting to recover that session, it will treat all keyserver sessions as being in recovery.

This diff switches us to tracking this recovery status on a per-keyserver basis.

Depends on D10680

Test Plan

I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable