HomePhabricator
Diffusion Comm 7f546eb9c1d8

[lib] Track session recovery on a per-keyserver basis

Description

[lib] Track session recovery on a per-keyserver basis

Summary:
The currentlyWaitingForNewCookie and serverEndpointCallsWaitingForNewCookie constants are global, which poses a problem. If a single keyserver returns a session invalidation to the client, then while the client is attempting to recover that session, it will treat all keyserver sessions as being in recovery.

This diff switches us to tracking this recovery status on a per-keyserver basis.

Depends on D10680

Test Plan:
I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Reviewers: tomek, inka, atul

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D10681

Details

Provenance
ashoatAuthored on Jan 10 2024, 1:41 PM
Reviewer
tomek
Differential Revision
D10681: [lib] Track session recovery on a per-keyserver basis
Parents
rCOMMcd712008bcb6: [lib] Avoid using same selector in useServerCall when paramOverride specified
Branches
Unknown
Tags
Unknown