Page MenuHomePhabricator

[lib] Extract useKeyserverCallInfos into separate file
ClosedPublic

Authored by ashoat on Jan 17 2024, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 6:06 PM
Unknown Object (File)
Tue, Oct 22, 4:59 PM
Unknown Object (File)
Tue, Oct 22, 4:59 PM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Sun, Oct 13, 11:47 PM
Unknown Object (File)
Sep 28 2024, 4:39 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Unknown Object (File)
Sep 5 2024, 11:53 PM
Subscribers
None

Details

Summary

In a later diff, I want to use this utility from CallKeyserverEndpointProvider. This would introduce a require cycle currently, since keyserver-call.js depends on CallKeyserverEndpointProvider. To avoid the require cycle, I'm extracting it into a separate file. This is probably a good idea for code hygiene anyways.

Depends on D10685

Test Plan

I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
lib/utils/keyserver-call.js
86 ↗(On Diff #35756)

Why do we have to type this as an Object?

This revision is now accepted and ready to land.Jan 18 2024, 5:32 AM
lib/utils/keyserver-call.js
86 ↗(On Diff #35756)

It's because the return type of CallSingleKeyserverEndpoint is Promise<Object>. We actually have a task to improve this: ENG-4968