Noticed that the pending messages in my test plan would get erased on LOG_IN_SUCCESS during session recovery. This diff makes sure we don't lose those pending messages.
Depends on D10695
Differential D10696 Authored by ashoat on Jan 18 2024, 12:51 AM.
Details Summary Noticed that the pending messages in my test plan would get erased on LOG_IN_SUCCESS during session recovery. This diff makes sure we don't lose those pending messages. NOTE: I wanted to check if the logged-in user has changed, but we can't make it until ENG-6126 is complete. That said, this should be a redundant check.
Depends on D10695 Test Plan I tested this stack using the following procedure:
Diff Detail
Event Timelineashoat added a child revision: D10697: [lib] Fix order of resolving keyserver calls after session recovery. Harbormaster completed remote builds in B25872: Diff 35767.Jan 18 2024, 1:32 AM2024-01-18 01:32:18 (UTC-8) This revision is now accepted and ready to land.Jan 18 2024, 6:57 AM2024-01-18 06:57:13 (UTC-8)
Harbormaster completed remote builds in B25908: Diff 35809.Jan 18 2024, 10:11 AM2024-01-18 10:11:56 (UTC-8) Closed by commit rCOMM077530051e77: [lib] Don't delete pending messages during session recovery (authored by ashoat). · Explain WhyJan 18 2024, 10:54 AM2024-01-18 10:54:16 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 35809 lib/reducers/message-reducer.js
|
These were just moved down (with useKeyboardHeight replaced by useRatchetingKeyboardHeight)