Page MenuHomePhabricator

[native] Extract useKeyboardHeight from LoggedOutModal
ClosedPublic

Authored by ashoat on May 24 2024, 1:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 9:08 PM
Unknown Object (File)
Fri, Nov 1, 9:52 PM
Unknown Object (File)
Mon, Oct 28, 11:41 PM
Unknown Object (File)
Mon, Oct 28, 5:23 PM
Unknown Object (File)
Fri, Oct 18, 2:11 AM
Unknown Object (File)
Sat, Oct 12, 1:50 AM
Unknown Object (File)
Sat, Oct 12, 1:19 AM
Unknown Object (File)
Thu, Oct 10, 7:40 PM
Subscribers

Details

Summary

We'll want to use this (with slight modifications) in the next diff, where we convert LoggedOutModal to Reanimated 2 syntax.

Depends on D12198

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/account/logged-out-modal.react.js
311 ↗(On Diff #40609)

I converted this from a ref to a state. This wasn't strictly necessary, since it's only used for a "spot check". I could have instead passing the ref in directly, but not its value (passing the value in directly would mean that keyboardHeightInput might have outdated values).

I decided against passing the ref in directly since it just seemed a bit messier, but I can do that if preferred.

This revision is now accepted and ready to land.May 24 2024, 7:43 AM