Page MenuHomePhabricator

[native] Reduce indentation of LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 9:08 PM
Unknown Object (File)
Sep 26 2024, 1:17 AM
Unknown Object (File)
Sep 26 2024, 1:17 AM
Unknown Object (File)
Sep 26 2024, 1:16 AM
Unknown Object (File)
Sep 26 2024, 1:14 AM
Unknown Object (File)
Sep 11 2024, 4:01 AM
Unknown Object (File)
Aug 26 2024, 6:27 PM
Unknown Object (File)
Aug 26 2024, 6:27 PM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

By moving the React.memo wrapper to the end, we're able to reduce the indentation.

This is the final diff in the LoggedOutModal -> function component refactor!

Depends on D12197

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable