Page MenuHomePhabricator

[native] Inline siweButton in LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 2:45 PM
Unknown Object (File)
Tue, Apr 15, 9:42 AM
Unknown Object (File)
Mon, Apr 14, 10:12 PM
Unknown Object (File)
Sun, Apr 13, 7:59 PM
Unknown Object (File)
Mar 6 2025, 1:22 AM
Unknown Object (File)
Feb 27 2025, 11:27 PM
Unknown Object (File)
Feb 27 2025, 2:20 AM
Unknown Object (File)
Feb 26 2025, 8:40 AM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Not clear why this was defined separately. Maybe it was used in multiple places previously?

Doing this as a separate diff because it's a simple move, to make later diffs easier to review.

Depends on D12192

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable