[native] Avoid showing iCloud password manager prompt when dismissing LogInPanel
ClosedPublic
Actions

Authored by ashoat on May 24 2024, 1:34 AM.

Details

Reviewers

inka

Commits

rCOMM97c26e6c172e: [native] Avoid showing iCloud password manager prompt when dismissing LogInPanel

Summary

For some reason, this prompt now appears when the LogInPanel is dismissed. It seems that switching to Reanimated 2 syntax here changed something about how the iOS password manager logic works with our code. (One big plus is that in LogInPanel, the username and password are now autocompleted together, instead of requiring two separate steps – cc @varun, who previously talked about this with me.)

Anyways: it makes sense to show this prompt when the user attempts a login, but not when the user goes back.

To avoid showing the prompt, we can clear the password TextInput before it disappears from the screen.

Depends on D12208

Test Plan

before	after

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 24 2024, 1:34 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2024, 1:34 AM

ashoat edited the test plan for this revision. (Show Details)May 24 2024, 1:37 AM

Harbormaster completed remote builds in B29222: Diff 40611.May 24 2024, 1:58 AM

ashoat requested review of this revision.May 24 2024, 1:58 AM

ashoat added inline comments.May 24 2024, 2:08 AM

native/account/logged-out-modal.react.js
326–328 ↗	(On Diff #40611)	This was moved lower and renamed to `finishResettingToPrompt`. It's only used in one place (passed to `getPanelOpacity`)

ashoat edited the summary of this revision. (Show Details)May 24 2024, 2:40 AM

ashoat edited the summary of this revision. (Show Details)

ashoat added a subscriber: varun.

inka added inline comments.May 24 2024, 9:07 AM

native/account/logged-out-modal.react.js
398 ↗	(On Diff #40611)	Is it necessary to only do this for iOS? In `finishResettingToPrompt` `setLogInState({ passwordInputText: temporarilyHiddenPassword.current });` is called at all times, which feels inconsistent.

ashoat added inline comments.May 24 2024, 9:57 AM

native/account/logged-out-modal.react.js
398 ↗	(On Diff #40611)	Only iOS has this behavior. The call you mention in `finishResettingToPrompt` is gated on `temporarilyHiddenPassword.current` being set, which won't happen on Android. If for some reason in the future we do set it on Android, I think it would make sense for that call to be triggered, but this is a purely hypothetical conversation