[native] Move StateContainer in LoggedOutModal to function component
ClosedPublic
Actions

Authored by ashoat on Wed, May 22, 7:39 AM.

Details

Reviewers

inka

Commits

rCOMM558a111df844: [native] Move StateContainer in LoggedOutModal to function component

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

I navigated to LogInPanel and back
I navigated to LegacyRegisterPanel and back
I navigated to FullscreenSIWEPanel and back
I navigated to QRCodeSignInNavigator and back
I navigated to Registration and back

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, May 22, 7:39 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, May 22, 7:39 AM

ashoat added a child revision: D12181: [native] Move mode/nextMode state in LoggedOutModal to function component.Wed, May 22, 7:40 AM

Harbormaster completed remote builds in B29179: Diff 40550.Wed, May 22, 8:11 AM

ashoat requested review of this revision.Wed, May 22, 8:11 AM

inka added inline comments.Fri, May 24, 3:15 AM

native/account/logged-out-modal.react.js
774–776 ↗	(On Diff #40550)	Why do we have to do this?

inka accepted this revision.Fri, May 24, 3:17 AM

This revision is now accepted and ready to land.Fri, May 24, 3:17 AM

ashoat added inline comments.Fri, May 24, 6:26 AM

native/account/logged-out-modal.react.js
774–776 ↗	(On Diff #40550)	To be honest, I'm not entirely sure, but I thought it was safer to keep the logic as-is. This is ported over from `guardedSetState`, which was previously passed in to `setStateForContainer`, which created the old `setLogInState`