Page MenuHomePhabricator

[native] Move StateContainer in LoggedOutModal to function component
ClosedPublic

Authored by ashoat on May 22 2024, 7:39 AM.
Tags
None
Referenced Files
F3353680: D12180.diff
Sat, Nov 23, 10:53 AM
Unknown Object (File)
Tue, Nov 12, 12:15 PM
Unknown Object (File)
Tue, Nov 12, 9:57 AM
Unknown Object (File)
Sat, Nov 9, 6:18 PM
Unknown Object (File)
Sat, Nov 9, 5:01 PM
Unknown Object (File)
Fri, Nov 8, 11:24 PM
Unknown Object (File)
Sun, Nov 3, 9:08 PM
Unknown Object (File)
Sep 28 2024, 2:53 PM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/account/logged-out-modal.react.js
774–776 ↗(On Diff #40550)

Why do we have to do this?

This revision is now accepted and ready to land.May 24 2024, 3:17 AM
native/account/logged-out-modal.react.js
774–776 ↗(On Diff #40550)

To be honest, I'm not entirely sure, but I thought it was safer to keep the logic as-is. This is ported over from guardedSetState, which was previously passed in to setStateForContainer, which created the old setLogInState