Page MenuHomePhabricator

[native] Reduce indentation of LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:46 AM.
Tags
None
Referenced Files
F2112029: D12198.diff
Wed, Jun 26, 12:32 AM
Unknown Object (File)
Sat, Jun 22, 3:59 AM
Unknown Object (File)
Sat, Jun 22, 3:59 AM
Unknown Object (File)
Sat, Jun 22, 3:58 AM
Unknown Object (File)
Sat, Jun 22, 3:57 AM
Unknown Object (File)
Fri, Jun 21, 6:09 AM
Unknown Object (File)
Wed, Jun 19, 11:28 PM
Unknown Object (File)
Sat, Jun 8, 8:07 PM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

By moving the React.memo wrapper to the end, we're able to reduce the indentation.

This is the final diff in the LoggedOutModal -> function component refactor!

Depends on D12197

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable