Page MenuHomePhabricator

[native] Extract useKeyboardHeight from LoggedOutModal
ClosedPublic

Authored by ashoat on May 24 2024, 1:32 AM.
Tags
None
Referenced Files
F3353624: D12207.diff
Sat, Nov 23, 10:36 AM
Unknown Object (File)
Thu, Nov 14, 8:03 PM
Unknown Object (File)
Wed, Nov 13, 11:44 PM
Unknown Object (File)
Wed, Nov 13, 11:02 PM
Unknown Object (File)
Sat, Nov 9, 4:59 PM
Unknown Object (File)
Sat, Nov 9, 12:13 PM
Unknown Object (File)
Fri, Nov 8, 11:24 PM
Unknown Object (File)
Thu, Nov 7, 10:11 PM
Subscribers

Details

Summary

We'll want to use this (with slight modifications) in the next diff, where we convert LoggedOutModal to Reanimated 2 syntax.

Depends on D12198

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/account/logged-out-modal.react.js
311

I converted this from a ref to a state. This wasn't strictly necessary, since it's only used for a "spot check". I could have instead passing the ref in directly, but not its value (passing the value in directly would mean that keyboardHeightInput might have outdated values).

I decided against passing the ref in directly since it just seemed a bit messier, but I can do that if preferred.

This revision is now accepted and ready to land.May 24 2024, 7:43 AM