HomePhabricator
Diffusion Comm 115e490e58c1

[native] Migrate from react-native-fast-image to expo-image

Description

[native] Migrate from react-native-fast-image to expo-image

Summary:
More context in ENG-3379.

I wasn't able to get expo-image to compile alongside react-native-fast-image due to conflicting Pod dependencies on SDWebImage, so I just went with a wholesale replacement.

Test Plan:
Here's how I tested:

  1. Open up iOS simulator and Android emulator
  2. Send message from iOS to Android. Confirm it renders on both sides, ideally without any transition delay on the sending side between local and remote URIs
  3. Same as 3 but from Android to iOS
  4. Make sure image copy still works on iOS (we use SDWebImage directly in patches/@react-native-clipboard+clipboard+1.11.1.patch)

I did all of these steps once with dev buils on iOS / Android, and another again with release builds for both.

Then, separately, I was able to confirm that it could render an SVG data URI on iOS / Android and in dev / release modes using this patch.

Reviewers: atul, bartek

Reviewed By: bartek

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7151

Details

Provenance
ashoatAuthored on Mar 22 2023, 5:10 PM
Reviewer
bartek
Differential Revision
D7151: [native] Migrate from react-native-fast-image to expo-image
Parents
rCOMM9acddb4cd20d: [desktop] Stop checking for a new version after download
Branches
Unknown
Tags
Unknown