[native] Migrate from react-native-fast-image to expo-image
ClosedPublic
Actions

Authored by ashoat on Mar 22 2023, 5:13 PM.

Details

Reviewers

atul
bartek

Commits

rCOMM115e490e58c1: [native] Migrate from react-native-fast-image to expo-image

Summary

More context in ENG-3379.

I wasn't able to get expo-image to compile alongside react-native-fast-image due to conflicting Pod dependencies on SDWebImage, so I just went with a wholesale replacement.

Test Plan

Here's how I tested:

Open up iOS simulator and Android emulator
Send message from iOS to Android. Confirm it renders on both sides, ideally without any transition delay on the sending side between local and remote URIs
Same as 3 but from Android to iOS
Make sure image copy still works on iOS (we use SDWebImage directly in patches/@react-native-clipboard+clipboard+1.11.1.patch)

I did all of these steps once with dev buils on iOS / Android, and another again with release builds for both.

Then, separately, I was able to confirm that it could render an SVG data URI on iOS / Android and in dev / release modes using this patch.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 22 2023, 5:13 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 22 2023, 5:13 PM

Harbormaster completed remote builds in B17539: Diff 24010.Mar 22 2023, 5:28 PM

ashoat requested review of this revision.Mar 22 2023, 5:28 PM

ashoat edited the test plan for this revision. (Show Details)Mar 22 2023, 5:58 PM

Done testing!! I think this is safe to land. I haven't tested blurhash or SVG / data URI support yet, but those are things that react-native-fast-image can't handle today anyways

Just tested and it looks like this solves rendering SVG data URIs for us!! I haven't tested other types, but PNG, JPEG, and SVG are all listed as supported in the docs. Thanks @bartek for the tip! This is way better than what I had planned to do on Android.

ashoat edited the test plan for this revision. (Show Details)Mar 22 2023, 9:16 PM

In D7151#212209, @ashoat wrote:

Just tested and it looks like this solves rendering SVG data URIs for us!! I haven't tested other types, but PNG, JPEG, and SVG are all listed as supported in the docs. Thanks @bartek for the tip! This is way better than what I had planned to do on Android.

That's great news! I'll patch this and test if it works with my decrypted image data too

It seems to work with all data URIs too!

Also, I was able to quickly set up some example blurhash (hardcoded for now) and display it while images are being decrypted.