HomePhabricator
Diffusion Comm 13b3ce70a796

[native] Stop using ReanimatedJSIModulePackage on Android

Description

[native] Stop using ReanimatedJSIModulePackage on Android

Summary:
While investigating ENG-7696, I noticed this log being printed:

[REANIMATED]: Since 2.5.0, Reanimated autoinstalls on Android - you can remove getJSIModulePackage() override in MainApplication.java.

It looks like it's coming from here, which confirms that ReanimatedJSIModulePackage is no longer doing anything and is deprecated.

This diff replaces our extension of ReanimatedJSIModulePackage with an implementation of its interface JSIModulePackage.

Depends on D11660

Test Plan:

  1. Confirm that Reanimated still works in Android simulator
  2. Confirm that the log message is no longer printed

Reviewers: marcin, tomek

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D11663

Details

Provenance
ashoatAuthored on Apr 15 2024, 4:37 AM
Reviewer
tomek
Differential Revision
D11663: [native] Stop using ReanimatedJSIModulePackage on Android
Parents
rCOMM7afb2d14a6a8: [lib] Use useDerivedObject to reduce renders due to preRequestUserState
Branches
Unknown
Tags
Unknown