Paths

Table of Contentst

[native] Stop using ReanimatedJSIModulePackage on Android
ClosedPublic
Actions

Authored by ashoat on Apr 15 2024, 4:41 AM.

Details

Reviewers

marcin
tomek

Commits

rCOMM13b3ce70a796: [native] Stop using ReanimatedJSIModulePackage on Android

Summary

While investigating ENG-7696, I noticed this log being printed:

[REANIMATED]: Since 2.5.0, Reanimated autoinstalls on Android - you can remove getJSIModulePackage() override in MainApplication.java.

It looks like it's coming from here, which confirms that ReanimatedJSIModulePackage is no longer doing anything and is deprecated.

This diff replaces our extension of ReanimatedJSIModulePackage with an implementation of its interface JSIModulePackage.

Depends on D11660

Test Plan

Confirm that Reanimated still works in Android simulator
Confirm that the log message is no longer printed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Replace extends with implements

ashoat edited the summary of this revision. (Show Details)Apr 15 2024, 4:43 AM

Harbormaster completed remote builds in B28218: Diff 39114.Apr 15 2024, 5:21 AM

ashoat requested review of this revision.Apr 15 2024, 5:21 AM

Harbormaster failed remote builds in B28217: Diff 39113!Apr 15 2024, 5:35 AM

tomek accepted this revision.Apr 15 2024, 7:28 AM

This revision is now accepted and ready to land.Apr 15 2024, 7:28 AM

Closed by commit rCOMM13b3ce70a796: [native] Stop using ReanimatedJSIModulePackage on Android (authored by ashoat). · Explain WhyApr 15 2024, 9:43 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM13b3ce70a796: [native] Stop using ReanimatedJSIModulePackage on Android.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

CommCoreJSIModulePackage.java

5 lines

Diff 39133

View Options

native/android/app/src/main/java/app/comm/android/CommCoreJSIModulePackage.java

[native] Stop using ReanimatedJSIModulePackage on AndroidClosedPublicActions