Page MenuHomePhabricator
Differential D11663

[native] Stop using ReanimatedJSIModulePackage on Android
ClosedPublic
Actions

Authored by ashoat on Apr 15 2024, 4:41 AM.
Tags
None
Referenced Files
F4952258: D11663.diff
Thu, Mar 20, 7:19 PM
Unknown Object (File)
Mon, Mar 10, 7:00 AM
Unknown Object (File)
Sat, Mar 8, 5:14 AM
Unknown Object (File)
Sat, Mar 8, 5:14 AM
Unknown Object (File)
Sat, Mar 8, 5:14 AM
Unknown Object (File)
Sat, Mar 8, 5:14 AM
Unknown Object (File)
Sat, Mar 8, 5:13 AM
Unknown Object (File)
Jan 19 2025, 2:59 PM
View All 66 Files
Subscribers
None

Details

Reviewers
marcin
tomek
Commits
rCOMM13b3ce70a796: [native] Stop using ReanimatedJSIModulePackage on Android
Summary

While investigating ENG-7696, I noticed this log being printed:

[REANIMATED]: Since 2.5.0, Reanimated autoinstalls on Android - you can remove getJSIModulePackage() override in MainApplication.java.

It looks like it's coming from here, which confirms that ReanimatedJSIModulePackage is no longer doing anything and is deprecated.

This diff replaces our extension of ReanimatedJSIModulePackage with an implementation of its interface JSIModulePackage.

Depends on D11660

Test Plan
  1. Confirm that Reanimated still works in Android simulator
  2. Confirm that the log message is no longer printed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
5 lines

Diff 39133

View Options

native/android/app/src/main/java/app/comm/android/CommCoreJSIModulePackage.java

Loading...