This diff prevents the Android app from getting into a state that causes a crash loop, described in ENG-7696. It however does not resolve the crash loop if it already occurring.
Details
Details
- Deleted the app off the simulator and redeployed, and the problem was gone (app stopped crash looping after being closed/reopened)
- Deployed this fix to production and confirmed it fixed the issue for all 3 users that were affected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I believe because it executes later. More details here. My thinking was that it's safe to call from CommHybrid, since it's called from CommCoreJSIModulePackage.getJSIModules.
Since by that point other JSI libraries (presuamably including Expo libraries) seem ready for setup, I figured it was safe to call SecureStore from that location.
Comment Actions
Maybe we can call it from getJSIModules? We're calling CommSecureStore.getInstance().initialize(secureStoreModuleSupplier); there and it is somehow connected.
Comment Actions
Maybe we can call it from getJSIModules? We're calling CommSecureStore.getInstance().initialize(secureStoreModuleSupplier); there and it is somehow connected.
Probably a good idea. I'll test and confirm that this still works before landing.