HomePhabricator
Diffusion Comm 16b1b1e50d45

[identity] Relax conditions for device list reorder

Description

[identity] Relax conditions for device list reorder

Summary:
Address ENG-9272.
Made v1 login RPCs able to reorder device list even if new logout flow was used (DDB devices data doesn't match device list).
Updated some log messages to be more meaningful and used redact_sensitive_data in more places.

Test Plan:

  • Registered a user
  • Used "Primary device logout" to log out. This left a singleton device list on Identity.
  • Logged in with v1 Login on mobile.
    • Device list was reordered. An info log was displayed about mismatch but no error.
  • Manually modified DDB to contain device that is not on device list
  • Used v1 login. Warn was displayed about corrupt state

Reviewers: varun

Reviewed By: varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D13421

Details

Provenance
bartekAuthored on Sep 21 2024, 5:30 AM
Reviewer
varun
Differential Revision
D13421: [identity] Relax conditions for device list reorder
Parents
rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set
Branches
Unknown
Tags
Unknown