Page MenuHomePhabricator
Differential D13421

[identity] Relax conditions for device list reorder
ClosedPublic
Actions

Authored by bartek on Sep 23 2024, 2:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 1:56 AM
Unknown Object (File)
Fri, Nov 8, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Wed, Oct 30, 11:25 PM
Unknown Object (File)
Wed, Oct 30, 11:25 PM
View All 31 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder
Summary

Address ENG-9272.
Made v1 login RPCs able to reorder device list even if new logout flow was used (DDB devices data doesn't match device list).
Updated some log messages to be more meaningful and used redact_sensitive_data in more places.

Test Plan
  • Registered a user
  • Used "Primary device logout" to log out. This left a singleton device list on Identity.
  • Logged in with v1 Login on mobile.
    • Device list was reordered. An info log was displayed about mismatch but no error.
  • Manually modified DDB to contain device that is not on device list
  • Used v1 login. Warn was displayed about corrupt state

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Sep 23 2024, 2:54 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 23 2024, 2:54 AM
Harbormaster completed remote builds in B31761: Diff 44407.Sep 23 2024, 3:11 AM
bartek published this revision for review.Sep 23 2024, 3:33 AM
varun accepted this revision.Sep 24 2024, 11:47 AM
varun added inline comments.
services/identity/src/database/device_list.rs
1950 ↗(On Diff #44407)
This revision is now accepted and ready to land.Sep 24 2024, 11:47 AM
Closed by commit rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder (authored by bartek). · Explain WhySep 25 2024, 8:36 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM16b1b1e50d45: [identity] Relax conditions for device list reorder.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
38 lines

Diff 44553

View Options

services/identity/src/database/device_list.rs

Loading...