HomePhabricator
Diffusion Comm 1c8fd0995bab

[web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`

Description

[web] Compute existingRole instead of existingRoleID in RoleActionsMenu

Summary:
This should be a noop refactor that I'm separating into separate diff to make next diff easier to remove.

We basically grab the RoleInfo instead of the RoleInfo.id so that we can access the specialRole field and deprecate useRoleDeletableAndEditableStatus.


Depends on D11205

Test Plan: flow, the invariant, logging the value, making sure RoleActionsMenu continues to look/work as expected

Reviewers: ginsu, tomek, kamil, michal

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11206

Details

Provenance
atulAuthored on Mar 18 2024, 2:17 PM
Reviewer
tomek
Differential Revision
D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`
Parents
rCOMM31f3b9f2cdd2: [web] Stop setting CSAT on initial redux state action
Branches
Unknown
Tags
Unknown