[web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 12:21 PM.

Details

Reviewers

ginsu
tomek
kamil
michal

Commits

rCOMM1c8fd0995bab: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`

Summary

This should be a noop refactor that I'm separating into separate diff to make next diff easier to remove.

We basically grab the RoleInfo instead of the RoleInfo.id so that we can access the specialRole field and deprecate useRoleDeletableAndEditableStatus.

Depends on D11205

Test Plan

flow, the invariant, logging the value, making sure RoleActionsMenu continues to look/work as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 1 2024, 12:21 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 1 2024, 12:21 PM

Harbormaster completed remote builds in B27253: Diff 37730.Mar 1 2024, 12:35 PM

atul requested review of this revision.Mar 1 2024, 12:35 PM

atul added a child revision: D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.Mar 1 2024, 12:58 PM

tomek accepted this revision.Mar 4 2024, 12:59 AM

This revision is now accepted and ready to land.Mar 4 2024, 12:59 AM

rebase around other diffs

Harbormaster completed remote builds in B27567: Diff 38147.Mar 18 2024, 2:33 PM

Closed by commit rCOMM1c8fd0995bab: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu` (authored by atul). · Explain WhyMar 19 2024, 9:53 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1c8fd0995bab: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.

Revision Contents
Changeset List

Path

Size

web/

roles/

role-actions-menu.react.js

22 lines

Diff 38191

View Options

web/roles/role-actions-menu.react.js

[web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`ClosedPublicActions