Paths

Table of Contentst

Differential D11311

[lib] Separate `serverThreadFrozenDueToBlock` and `clientThreadFrozenDueToBlock`
AbandonedPublic
Actions

Authored by atul on Mar 12 2024, 8:56 AM.

Tags

None

Referenced Files

	F3181747: D11311.diff
	Fri, Nov 8, 6:46 AM

	Unknown Object (File)
	Tue, Oct 15, 8:18 PM

	Unknown Object (File)
	Tue, Oct 15, 8:17 PM

	Unknown Object (File)
	Tue, Oct 15, 8:17 PM

	Unknown Object (File)
	Tue, Oct 15, 8:17 PM

	Unknown Object (File)
	Sep 4 2024, 2:26 PM

	Unknown Object (File)
	Sep 4 2024, 2:26 PM

	Unknown Object (File)
	Sep 4 2024, 2:26 PM

View All 51 Files

Subscribers

Details

Reviewers

tomek
ginsu
michal
kamil

Summary

Updating all of the threadFrozenDueToBlock callsites on keyserver is going to be involved. I started working on it, but it required changing a bunch of functionality in keyserver/lib/etc.

I will still consolidate the logic in this stack, specifically to avoid the sketchy CHANGE_ROLE check for server variant of function... but will sequence that after figuring out everything on client.

Depends on D11308

Test Plan

Straightforward refactor, find/replace + flow

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 12 2024, 8:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 12 2024, 8:56 AM

Harbormaster completed remote builds in B27475: Diff 38024.Mar 12 2024, 9:11 AM

atul requested review of this revision.Mar 12 2024, 9:11 AM

narrow type

Harbormaster completed remote builds in B27481: Diff 38030.Mar 12 2024, 11:00 AM

atul added a child revision: D11317: [lib] Update `clientThreadFrozenDueToBlock` and `getMinimallyEncodedCurrentUser` signatures to include `communityThreadInfo`.Mar 13 2024, 12:35 PM

Separate serverThreadFrozenDueToBlock and clientThreadFrozenDueToBlock

Why do we want to do that?

lib/shared/thread-utils.js
1053	Should we move this function to `keyserver`?

This revision is now accepted and ready to land.Mar 19 2024, 5:04 AM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-permission-fetchers.js

4 lines

lib/

shared/

thread-utils.js

17 lines

Diff 38030

keyserver/src/fetchers/thread-permission-fetchers.js

Loading...

lib/shared/thread-utils.js

Loading...