Paths

Table of Contentst

Differential D11204

[web][native][keyserver] Flip the switch to enable `specialRole` field
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 10:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 3, 2:22 AM

	Unknown Object (File)
	Wed, Apr 3, 2:22 AM

	Unknown Object (File)
	Wed, Apr 3, 2:22 AM

	Unknown Object (File)
	Sun, Mar 31, 12:02 AM

	Unknown Object (File)
	Mar 13 2024, 5:58 AM

	Unknown Object (File)
	Mar 13 2024, 4:28 AM

	Unknown Object (File)
	Mar 9 2024, 4:24 PM

	Unknown Object (File)
	Mar 7 2024, 7:54 AM

View All 14 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field
rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field

Summary

This diff will need to be landed at the same time as a release/codeVersion bump so things don't break in developer's local environment.

Will send message in Releases channel when ready.

Depends on D11188

Test Plan

Have a local "do not land" diff that does this locally and things work as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 1 2024, 10:43 AM

Harbormaster completed remote builds in B27251: Diff 37728.Mar 1 2024, 11:06 AM

atul requested review of this revision.Mar 1 2024, 11:06 AM

atul edited the summary of this revision. (Show Details)Mar 1 2024, 11:42 AM

atul added a parent revision: D11188: [web] Redux migration to patch in `specialRole` field.

atul added a child revision: D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.Mar 1 2024, 12:03 PM

ashoat added inline comments.Mar 1 2024, 1:32 PM

keyserver/src/fetchers/thread-fetchers.js
291 ↗	(On Diff #37728)	Should this variable be renamed?

Just going to accept this to move it off my queue, but in our 1:1 @atul mentioned he still wanted to do some additional testing before landing

This revision is now accepted and ready to land.Mar 1 2024, 3:14 PM

amend

atul added inline comments.Mon, Apr 22, 11:26 AM

keyserver/src/fetchers/thread-fetchers.js
289–290 ↗	(On Diff #39352)	Bumping these in D11188 and D11099 which will be landed immediately after `keyserver` release. Can change to `NEXT_CODE_VERSION`, but want to make clear that we don't actually need mobile releases... just need to bump the values.

Harbormaster completed remote builds in B28362: Diff 39352.Mon, Apr 22, 11:35 AM

land

This revision was landed with ongoing or failed builds.Mon, Apr 22, 12:12 PM

Closed by commit rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field.

atul added a reverting change: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".Mon, Apr 22, 12:26 PM

Harbormaster completed remote builds in B28368: Diff 39358.Mon, Apr 22, 12:33 PM

atul reopened this revision.Mon, Apr 22, 1:31 PM

This revision is now accepted and ready to land.Mon, Apr 22, 1:31 PM

amend

change web minCodeVersion to NEXT_CODE_VERSION

This revision was landed with ongoing or failed builds.Mon, Apr 22, 6:34 PM

Closed by commit rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field.

Harbormaster completed remote builds in B28390: Diff 39384.Mon, Apr 22, 6:40 PM

Harbormaster completed remote builds in B28391: Diff 39385.Mon, Apr 22, 6:45 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

11 lines

Diff 39386

keyserver/src/fetchers/thread-fetchers.js

Loading...