Details
Details
This gets consumed for the first time in the upcoming specialRoles migration where it will be tested implicitly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Could you link to the code that you're reintroducing?
I specify the changes inline.
This seems to be missed.
Comment Actions
Sorry, added annotation showing original code.
native/redux/client-db-utils.js | ||
---|---|---|
29–53 ↗ | (On Diff #37280) | Here's the code it's based on: function deprecatedUpdateClientDBThreadStoreThreadInfos( state: AppState, migrationFunc: MixedRawThreadInfos => MixedRawThreadInfos, handleMigrationFailure?: AppState => AppState, ): AppState { // Get threads from SQLite `threads` table. const clientDBThreadInfos = commCoreModule.getAllThreadsSync(); const operations = deprecatedCreateUpdateDBOpsForThreadStoreThreadInfos( clientDBThreadInfos, migrationFunc, ); // Try processing `ClientDBThreadStoreOperation`s and log out if // `processThreadStoreOperationsSync(...)` throws an exception. try { commCoreModule.processThreadStoreOperationsSync(operations); } catch (exception) { console.log(exception); if (handleMigrationFailure) { return handleMigrationFailure(state); } return ({ ...state, cookie: null }: any); } return state; } As well as screenshot with correct syntax highlighting + type hints: |