Paths

Table of Contentst

-
lib/permissions/
-
permissions/
-
special-roles.js
-
special-roles.test.js

[lib] Introduce `patchRawThreadInfosWithSpecialRole()`
ClosedPublic
Actions

Authored by atul on Feb 13 2024, 1:41 PM.

Details

Reviewers

ginsu
tomek

Commits

rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`

Summary

This will be used as part of native migration to add specialRole field to RoleInfos. This function is (RawThreadInfos) => RawThreadInfos which we can pass to updateClientDBThreadStoreThreadInfos as the migrationFunc.

Test Plan

Unit tests. Want to test this behavior outside of the running app so it was easier to ensure correct behavior w/ debugger:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 13 2024, 1:41 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 13 2024, 1:41 PM

atul published this revision for review.Feb 13 2024, 1:46 PM

Harbormaster completed remote builds in B26799: Diff 37041.Feb 13 2024, 2:00 PM

atul added a child revision: D11057: [native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and `createUpdateDBOpsForThreadStoreThreadInfos`.Feb 13 2024, 2:06 PM

tomek accepted this revision.Feb 14 2024, 9:08 AM

tomek added inline comments.

lib/permissions/special-roles.test.js
217–225 ↗	(On Diff #37041)	Just for the completeness of the test it could make sense to check if the role isn't default or admin, we don't set the `specialRole` field.

This revision is now accepted and ready to land.Feb 14 2024, 9:08 AM

address @tomek's feedback

Harbormaster completed remote builds in B26930: Diff 37270.Feb 15 2024, 11:31 AM

Closed by commit rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()` (authored by atul). · Explain WhyFeb 15 2024, 11:33 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

special-roles.js

24 lines

special-roles.test.js

187 lines

Diff 37271

View Options

lib/permissions/special-roles.js

	Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
	describe('minimallyEncodedRoleInfoValidator', () => {			describe('minimallyEncodedRoleInfoValidator', () => {
	it('should validate correctly formed MinimallyEncodedRoleInfo', () => {			it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
	expect(			expect(
	roleInfoValidator.is({			roleInfoValidator.is({
	minimallyEncoded: true,			minimallyEncoded: true,
	id: 'roleID',			id: 'roleID',
	name: 'roleName',			name: 'roleName',
	permissions: ['abc', 'def'],			permissions: ['abc', 'def'],
	isDefault: true,
	specialRole: specialRoles.DEFAULT_ROLE,			specialRole: specialRoles.DEFAULT_ROLE,
	}),			}),
	).toBe(true);			).toBe(true);
	});			});

	it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {			it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
	expect(			expect(
	roleInfoValidator.is({			roleInfoValidator.is({
	▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines