Page MenuHomePhabricator
Differential D11056

[lib] Introduce `patchRawThreadInfosWithSpecialRole()`
ClosedPublic
Actions

Authored by atul on Feb 13 2024, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 3:17 AM
Unknown Object (File)
Oct 15 2024, 9:35 PM
Unknown Object (File)
Oct 15 2024, 9:35 PM
Unknown Object (File)
Oct 15 2024, 9:35 PM
Unknown Object (File)
Oct 15 2024, 9:35 PM
Unknown Object (File)
Oct 15 2024, 9:35 PM
Unknown Object (File)
Sep 4 2024, 3:22 PM
Unknown Object (File)
Sep 4 2024, 3:22 PM
View All 52 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
Commits
rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`
Summary

This will be used as part of native migration to add specialRole field to RoleInfos. This function is (RawThreadInfos) => RawThreadInfos which we can pass to updateClientDBThreadStoreThreadInfos as the migrationFunc.

Test Plan

Unit tests. Want to test this behavior outside of the running app so it was easier to ensure correct behavior w/ debugger:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 13 2024, 1:41 PM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 13 2024, 1:41 PM
atul published this revision for review.Feb 13 2024, 1:46 PM
Harbormaster completed remote builds in B26799: Diff 37041.Feb 13 2024, 2:00 PM
atul added a child revision: D11057: [native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and `createUpdateDBOpsForThreadStoreThreadInfos`.Feb 13 2024, 2:06 PM
tomek accepted this revision.Feb 14 2024, 9:08 AM
tomek added inline comments.
lib/permissions/special-roles.test.js
217–225

Just for the completeness of the test it could make sense to check if the role isn't default or admin, we don't set the specialRole field.

This revision is now accepted and ready to land.Feb 14 2024, 9:08 AM
atul updated this revision to Diff 37270.Feb 15 2024, 11:14 AM

address @tomek's feedback

Harbormaster completed remote builds in B26930: Diff 37270.Feb 15 2024, 11:31 AM
Closed by commit rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()` (authored by atul). · Explain WhyFeb 15 2024, 11:33 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`.

Revision Contents
Changeset List

PathSize
lib/
permissions/
24 lines
187 lines

Diff 37041

View Options

lib/permissions/special-roles.js

Loading...
View Options

lib/permissions/special-roles.test.js

Loading...