Paths

Table of Contentst

Differential D11208

[lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 12:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 7:47 AM

	Unknown Object (File)
	Tue, Dec 24, 7:47 AM

	Unknown Object (File)
	Tue, Dec 24, 7:47 AM

	Unknown Object (File)
	Tue, Dec 24, 7:47 AM

	Unknown Object (File)
	Tue, Dec 24, 7:47 AM

	Unknown Object (File)
	Tue, Dec 10, 9:45 PM

	Unknown Object (File)
	Mon, Dec 9, 6:30 AM

	Unknown Object (File)
	Sun, Dec 8, 11:25 AM

View All 67 Files

Subscribers

Details

Reviewers

ginsu
tomek
kamil
michal

Commits

rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is…

Summary

Context: https://linear.app/comm/issue/ENG-6949/update-roledeletableandeditablestatus-to-use-specialrole-field

We can use specialRole field and roleIsDefaultRole and roleIsAdminRole utilities directly instead of doing this in a separate hook.

Depends on D11206

Test Plan

Make sure that RoleActionsMenu appears and behaves as expected.

Will put screenshots in here shortly:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 1 2024, 12:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 1 2024, 12:58 PM

Harbormaster completed remote builds in B27257: Diff 37734.Mar 1 2024, 1:13 PM

atul requested review of this revision.Mar 1 2024, 1:13 PM

atul added a child revision: D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.Mar 1 2024, 1:16 PM

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

This revision is now accepted and ready to land.Mar 4 2024, 1:05 AM

This is safe to land because we will fall back to previous roleIsAdminRole and roleIsDefaultRole logic if specialRole field is missing (as it will on web when landed prior to "flipping the switch").

In D11208#324212, @tomek wrote:

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

Yeah, agree but figure this reduces indirection for time being when there's a single instance.

rebase around and land

Harbormaster completed remote builds in B27605: Diff 38199.Mar 19 2024, 10:49 AM

Closed by commit rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is… (authored by atul). · Explain WhyMar 19 2024, 10:51 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is….

Revision Contents
Changeset List

Path

Size

lib/

utils/

21 lines

web/

roles/

role-actions-menu.react.js

15 lines

Diff 38200

lib/utils/role-utils.js

Loading...

web/roles/role-actions-menu.react.js

Loading...