Paths

Table of Contentst

-
lib/shared/
-
shared/
-
thread-utils.js

Differential D11248

[lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 2:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 19, 5:15 PM

	Unknown Object (File)
	Thu, Apr 17, 10:10 AM

	Unknown Object (File)
	Wed, Apr 16, 1:08 PM

	Unknown Object (File)
	Wed, Apr 16, 11:42 AM

	Unknown Object (File)
	Wed, Apr 16, 4:44 AM

	Unknown Object (File)
	Tue, Apr 15, 11:49 PM

	Unknown Object (File)
	Tue, Apr 15, 11:04 AM

	Unknown Object (File)
	Mar 18 2025, 5:38 AM

Subscribers

Details

Reviewers

tomek
ginsu
michal
kamil
ashoat

Commits

rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and…

Summary

Noticed as part of D11205 that these hooks had threadInfo in their dep list which wasn't necessary.

Depends on D11209

Test Plan

ESLint/Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 5 2024, 2:22 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 2:22 PM

Harbormaster completed remote builds in B27344: Diff 37865.Mar 5 2024, 2:37 PM

atul requested review of this revision.Mar 5 2024, 2:37 PM

ashoat accepted this revision.Mar 5 2024, 6:01 PM

This revision is now accepted and ready to land.Mar 5 2024, 6:01 PM

atul added a child revision: D11252: [lib] Make `specialRoles` field of `RoleInfo` required.Mar 5 2024, 9:20 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 19 2024, 10:28 AM

Closed by commit rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and….

Harbormaster completed remote builds in B27603: Diff 38196.Mar 19 2024, 10:41 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

4 lines

Diff 38197

lib/shared/thread-utils.js

	Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines		runtime_platform {
	cpu_architecture = "ARM64"			cpu_architecture = "ARM64"
	operating_system_family = "LINUX"			operating_system_family = "LINUX"
	}			}

	skip_destroy = false			skip_destroy = false
	}			}

	resource "aws_ecs_service" "keyserver_primary_service" {			resource "aws_ecs_service" "keyserver_primary_service" {
				depends_on = [null_resource.create_comm_database]

	name = "keyserver-primary-service"			name = "keyserver-primary-service"
	cluster = aws_ecs_cluster.keyserver_cluster.id			cluster = aws_ecs_cluster.keyserver_cluster.id
	task_definition = aws_ecs_task_definition.keyserver_service.arn			task_definition = aws_ecs_task_definition.keyserver_service.arn
	launch_type = "FARGATE"			launch_type = "FARGATE"
	enable_execute_command = true			enable_execute_command = true
	enable_ecs_managed_tags = true			enable_ecs_managed_tags = true
	force_new_deployment = true			force_new_deployment = true
	desired_count = 1			desired_count = 1
	▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines