Paths

Table of Contentst

-
lib/shared/
-
shared/
-
thread-utils.js

Differential D11248

[lib] Constrain dep list of `useRoleMemberCountsForCommunity` and `useRoleUserSurfacedPermissions`
ClosedPublic
Actions

Authored by atul on Mar 5 2024, 2:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 5:38 AM

	Unknown Object (File)
	Wed, Mar 12, 7:05 AM

	Unknown Object (File)
	Fri, Mar 7, 10:02 AM

	Unknown Object (File)
	Sat, Feb 22, 2:00 AM

	Unknown Object (File)
	Sat, Feb 22, 2:00 AM

	Unknown Object (File)
	Sat, Feb 22, 2:00 AM

	Unknown Object (File)
	Sat, Feb 22, 2:00 AM

	Unknown Object (File)
	Sat, Feb 22, 2:00 AM

View All 94 Files

Subscribers

Details

Reviewers

tomek
ginsu
michal
kamil
ashoat

Commits

rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and…

Summary

Noticed as part of D11205 that these hooks had threadInfo in their dep list which wasn't necessary.

Depends on D11209

Test Plan

ESLint/Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 5 2024, 2:22 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 2:22 PM

Harbormaster completed remote builds in B27344: Diff 37865.Mar 5 2024, 2:37 PM

atul requested review of this revision.Mar 5 2024, 2:37 PM

ashoat accepted this revision.Mar 5 2024, 6:01 PM

This revision is now accepted and ready to land.Mar 5 2024, 6:01 PM

atul added a child revision: D11252: [lib] Make `specialRoles` field of `RoleInfo` required.Mar 5 2024, 9:20 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 19 2024, 10:28 AM

Closed by commit rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM18ae66cdc3f9: [lib] Constrain dep list of `useRoleMemberCountsForCommunity` and….

Harbormaster completed remote builds in B27603: Diff 38196.Mar 19 2024, 10:41 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

4 lines

Diff 38197

lib/shared/thread-utils.js

	Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
	describe('minimallyEncodedRoleInfoValidator', () => {			describe('minimallyEncodedRoleInfoValidator', () => {
	it('should validate correctly formed MinimallyEncodedRoleInfo', () => {			it('should validate correctly formed MinimallyEncodedRoleInfo', () => {
	expect(			expect(
	roleInfoValidator.is({			roleInfoValidator.is({
	minimallyEncoded: true,			minimallyEncoded: true,
	id: 'roleID',			id: 'roleID',
	name: 'roleName',			name: 'roleName',
	permissions: ['abc', 'def'],			permissions: ['abc', 'def'],
	isDefault: true,
	specialRole: specialRoles.DEFAULT_ROLE,			specialRole: specialRoles.DEFAULT_ROLE,
	}),			}),
	).toBe(true);			).toBe(true);
	});			});

	it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {			it('should NOT validate malformed MinimallyEncodedRoleInfo', () => {
	expect(			expect(
	roleInfoValidator.is({			roleInfoValidator.is({
	▲ Show 20 Lines • Show All 303 Lines • Show Last 20 Lines