[lib] Update `clientThreadFrozenDueToBlock` and `getMinimallyEncodedCurrentUser` signatures to include `communityThreadInfo`
AbandonedPublic
Actions

Authored by atul on Mar 13 2024, 12:35 PM.

Details

Reviewers

tomek
ginsu
kamil
michal

Summary

Updating clientThreadFrozenDueToBlock and getMinimallyEncodedCurrentUser signatures to include communityThreadInfo.

Next step is to update useExistingThreadInfoFinder (which is easy) and threadInfoFromRawThreadInfo (which is hard and requires recursively updating all the callsites).

Will begin with useExistingThreadInfoFinder, and then update threadInfoFromRawThreadInfo and callsites, etc and proceed.

Depends on D11311

Test Plan

flow + careful reading

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 13 2024, 12:35 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 13 2024, 12:35 PM

atul added a child revision: D11318: [lib] Introduce `threadInfoFromRawThreadInfo` wrapper that computes `currentUser` and passes to `baseThreadInfoFromRawThreadInfo`.Mar 13 2024, 1:49 PM

Harbormaster completed remote builds in B27487: Diff 38044.Mar 13 2024, 8:56 PM

atul requested review of this revision.Mar 13 2024, 8:56 PM

It seems like changing the code to check permissions in communityThreadInfo is a huge amount of work. Could you explain why we have to do this and what are the consequences of not doing it?

This revision is now accepted and ready to land.Mar 19 2024, 5:11 AM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

13 lines

Diff 38044

View Options

lib/shared/thread-utils.js

[lib] Update `clientThreadFrozenDueToBlock` and `getMinimallyEncodedCurrentUser` signatures to include `communityThreadInfo`AbandonedPublicActions