Page MenuHomePhabricator
Differential D11252

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic
Actions

Authored by atul on Mar 5 2024, 9:20 PM.
Tags
None
Referenced Files
F3528014: D11252.id37873.diff
Tue, Dec 24, 7:48 AM
F3528013: D11252.id37871.diff
Tue, Dec 24, 7:48 AM
F3527992: D11252.id.diff
Tue, Dec 24, 7:47 AM
F3527978: D11252.diff
Tue, Dec 24, 7:47 AM
Unknown Object (File)
Thu, Dec 5, 10:49 AM
Unknown Object (File)
Mon, Nov 25, 4:05 AM
Unknown Object (File)
Sun, Nov 24, 5:14 PM
Unknown Object (File)
Nov 21 2024, 12:37 AM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
tomek
ginsu
michal
kamil
Summary

We now expect clients to get RoleInfos with the specialRole field included. We make the field required (it's still ?SpecialRole, so can be set to null) and make the necessary flow changes.

Depends on D11248

Test Plan

flow + verifying that clients recieve specialRole field in RoleInfo from keyserver responses.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:20 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:20 PM
atul added a child revision: D11253: [lib] Remove `isDefault` field from `RoleInfo`.Mar 5 2024, 9:28 PM
atul updated this revision to Diff 37873.Mar 5 2024, 9:32 PM

fix else case of patchRoleInfoWithSpecialRole

Harbormaster completed remote builds in B27349: Diff 37871.Mar 5 2024, 9:35 PM
Harbormaster completed remote builds in B27351: Diff 37873.Mar 5 2024, 9:51 PM
atul requested review of this revision.Mar 5 2024, 9:51 PM
tomek accepted this revision.Mar 6 2024, 4:21 AM
tomek added inline comments.
lib/types/minimally-encoded-thread-permissions-types.js
37

Maybe add an explicit null?

This revision is now accepted and ready to land.Mar 6 2024, 4:21 AM
atul abandoned this revision.Jul 7 2024, 9:56 PM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.

Revision Contents
Changeset List

Diff 37873

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

Loading...
View Options

lib/permissions/special-roles.js

Loading...
View Options

lib/permissions/special-roles.test.js

Loading...
View Options

lib/reducers/calendar-filters-reducer.test.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...