Paths

Table of Contentst

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic
Actions

Authored by atul on Mar 5 2024, 9:20 PM.

Details

Reviewers

tomek
ginsu
michal
kamil

Summary

We now expect clients to get RoleInfos with the specialRole field included. We make the field required (it's still ?SpecialRole, so can be set to null) and make the necessary flow changes.

Depends on D11248

Test Plan

flow + verifying that clients recieve specialRole field in RoleInfo from keyserver responses.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:20 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:20 PM

atul added a child revision: D11253: [lib] Remove `isDefault` field from `RoleInfo`.Mar 5 2024, 9:28 PM

fix else case of patchRoleInfoWithSpecialRole

Harbormaster completed remote builds in B27349: Diff 37871.Mar 5 2024, 9:35 PM

Harbormaster completed remote builds in B27351: Diff 37873.Mar 5 2024, 9:51 PM

atul requested review of this revision.Mar 5 2024, 9:51 PM

tomek accepted this revision.Mar 6 2024, 4:21 AM

tomek added inline comments.

lib/types/minimally-encoded-thread-permissions-types.js
37	Maybe add an explicit null?

This revision is now accepted and ready to land.Mar 6 2024, 4:21 AM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions-test-data.js

2 lines

special-roles.js

6 lines

special-roles.test.js

12 lines

reducers/

calendar-filters-reducer.test.js

4 lines

shared/

thread-utils.test.js

3 lines

types/

minimally-encoded-thread-permissions-types.js

11 lines

Diff 37873

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

View Options

lib/permissions/special-roles.js

View Options

lib/permissions/special-roles.test.js

View Options

lib/reducers/calendar-filters-reducer.test.js

View Options

lib/shared/thread-utils.test.js

View Options

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Make `specialRoles` field of `RoleInfo` requiredAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37873

lib/permissions/minimally-encoded-thread-permissions-test-data.js

lib/permissions/special-roles.js

lib/permissions/special-roles.test.js

lib/reducers/calendar-filters-reducer.test.js

lib/shared/thread-utils.test.js

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic
Actions

Revision Contents
Changeset List