Page MenuHomePhabricator

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic

Authored by atul on Mar 5 2024, 9:20 PM.
Tags
None
Referenced Files
F3332634: D11252.id.diff
Thu, Nov 21, 12:37 AM
Unknown Object (File)
Fri, Nov 8, 7:34 AM
Unknown Object (File)
Fri, Nov 8, 6:46 AM
Unknown Object (File)
Mon, Oct 28, 3:45 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:03 PM
Subscribers

Details

Summary

We now expect clients to get RoleInfos with the specialRole field included. We make the field required (it's still ?SpecialRole, so can be set to null) and make the necessary flow changes.


Depends on D11248

Test Plan

flow + verifying that clients recieve specialRole field in RoleInfo from keyserver responses.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

fix else case of patchRoleInfoWithSpecialRole

atul requested review of this revision.Mar 5 2024, 9:51 PM
tomek added inline comments.
lib/types/minimally-encoded-thread-permissions-types.js
37 ↗(On Diff #37873)

Maybe add an explicit null?

This revision is now accepted and ready to land.Mar 6 2024, 4:21 AM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.