[lib] Introduce `patchRawThreadInfosWithSpecialRole()`
ClosedPublic
Actions

Authored by atul on Feb 13 2024, 1:41 PM.

Details

Reviewers

ginsu
tomek

Commits

rCOMM9b9a18ca1180: [lib] Introduce `patchRawThreadInfosWithSpecialRole()`

Summary

This will be used as part of native migration to add specialRole field to RoleInfos. This function is (RawThreadInfos) => RawThreadInfos which we can pass to updateClientDBThreadStoreThreadInfos as the migrationFunc.

Test Plan

Unit tests. Want to test this behavior outside of the running app so it was easier to ensure correct behavior w/ debugger:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11056 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 13 2024, 1:41 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 13 2024, 1:41 PM

atul published this revision for review.Feb 13 2024, 1:46 PM

Harbormaster completed remote builds in B26799: Diff 37041.Feb 13 2024, 2:00 PM

atul added a child revision: D11057: [native] Deprecate and move `updateClientDBThreadStoreThreadInfos` and `createUpdateDBOpsForThreadStoreThreadInfos`.Feb 13 2024, 2:06 PM

tomek accepted this revision.Feb 14 2024, 9:08 AM

tomek added inline comments.

lib/permissions/special-roles.test.js
217–225 ↗	(On Diff #37041)	Just for the completeness of the test it could make sense to check if the role isn't default or admin, we don't set the `specialRole` field.