Page MenuHomePhabricator
Differential D11204

[web][native][keyserver] Flip the switch to enable `specialRole` field
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 8:57 AM
Unknown Object (File)
Tue, Mar 18, 7:05 AM
Unknown Object (File)
Fri, Mar 14, 4:57 AM
Unknown Object (File)
Fri, Mar 14, 4:48 AM
Unknown Object (File)
Fri, Mar 14, 4:43 AM
Unknown Object (File)
Wed, Mar 12, 5:01 PM
Unknown Object (File)
Fri, Mar 7, 7:33 AM
Unknown Object (File)
Mon, Mar 3, 3:15 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field
rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field
Summary

This diff will need to be landed at the same time as a release/codeVersion bump so things don't break in developer's local environment.

Will send message in Releases channel when ready.

Depends on D11188

Test Plan

Have a local "do not land" diff that does this locally and things work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 1 2024, 10:43 AM
Harbormaster completed remote builds in B27251: Diff 37728.Mar 1 2024, 11:06 AM
atul requested review of this revision.Mar 1 2024, 11:06 AM
atul edited the summary of this revision. (Show Details)Mar 1 2024, 11:42 AM
atul added a parent revision: D11188: [web] Redux migration to patch in `specialRole` field.
atul added a child revision: D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.Mar 1 2024, 12:03 PM
ashoat added inline comments.Mar 1 2024, 1:32 PM
keyserver/src/fetchers/thread-fetchers.js
291

Should this variable be renamed?

ashoat accepted this revision.Mar 1 2024, 3:14 PM

Just going to accept this to move it off my queue, but in our 1:1 @atul mentioned he still wanted to do some additional testing before landing

This revision is now accepted and ready to land.Mar 1 2024, 3:14 PM
atul updated this revision to Diff 39352.Apr 22 2024, 11:19 AM

amend

atul added inline comments.Apr 22 2024, 11:26 AM
keyserver/src/fetchers/thread-fetchers.js
289–290 ↗(On Diff #39352)

Bumping these in D11188 and D11099 which will be landed immediately after keyserver release.

Can change to NEXT_CODE_VERSION, but want to make clear that we don't actually need mobile releases... just need to bump the values.

Harbormaster completed remote builds in B28362: Diff 39352.Apr 22 2024, 11:35 AM
atul updated this revision to Diff 39358.Apr 22 2024, 12:10 PM

land

This revision was landed with ongoing or failed builds.Apr 22 2024, 12:12 PM
Closed by commit rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field.
atul added a reverting change: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".Apr 22 2024, 12:26 PM
Harbormaster completed remote builds in B28368: Diff 39358.Apr 22 2024, 12:33 PM
atul reopened this revision.Apr 22 2024, 1:31 PM
This revision is now accepted and ready to land.Apr 22 2024, 1:31 PM
atul updated this revision to Diff 39384.Apr 22 2024, 6:23 PM

amend

atul updated this revision to Diff 39385.Apr 22 2024, 6:25 PM

change web minCodeVersion to NEXT_CODE_VERSION

This revision was landed with ongoing or failed builds.Apr 22 2024, 6:34 PM
Closed by commit rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Harbormaster completed remote builds in B28390: Diff 39384.Apr 22 2024, 6:40 PM
Harbormaster completed remote builds in B28391: Diff 39385.Apr 22 2024, 6:45 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
8 lines
native/
redux/
2 lines
web/
redux/
2 lines

Diff 37728

View Options

keyserver/src/fetchers/thread-fetchers.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunction useFetchEntries(): (
calendarQuery: CalendarQuery, calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> { ) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries); return useKeyserverCall(fetchEntries);
} }
export type UpdateCalendarQueryInput = { export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean, +reduxAlreadyUpdated?: boolean,
+keyserverIDs?: $ReadOnlyArray<string>,
}; };
const updateCalendarQueryActionTypes = Object.freeze({ const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED', started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS', success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED', failed: 'UPDATE_CALENDAR_QUERY_FAILED',
}); });
const updateCalendarQuery = const updateCalendarQuery =
( (
callKeyserverEndpoint: CallKeyserverEndpoint, callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>, allKeyserverIDs: $ReadOnlyArray<string>,
): (( ): ((
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) => ) => Promise<CalendarQueryUpdateResult>) =>
async input => { async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input; const { calendarQuery, reduxAlreadyUpdated = false } = input;
const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;
const calendarQueries = sortCalendarQueryPerKeyserver( const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery, calendarQuery,
allKeyserverIDs, keyserverIDs,
); );
const requests: { [string]: CalendarQuery } = {}; const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) { for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID]; requests[keyserverID] = calendarQueries[keyserverID];
} }
const responses = await callKeyserverEndpoint( const responses = await callKeyserverEndpoint(
'update_calendar_query', 'update_calendar_query',
requests, requests,
); );
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = []; let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = []; let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) { for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat( rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos, responses[keyserverID].rawEntryInfos,
); );
deletedEntryIDs = deletedEntryIDs.concat( deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs, responses[keyserverID].deletedEntryIDs,
); );
} }
return { return {
rawEntryInfos, rawEntryInfos,
deletedEntryIDs, deletedEntryIDs,
calendarQuery, calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated, calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
keyserverIDs,
}; };
}; };
function useUpdateCalendarQuery(): ( function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> { ) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery); return useKeyserverCall(updateCalendarQuery);
} }
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

native/redux/persist.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunction useFetchEntries(): (
calendarQuery: CalendarQuery, calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> { ) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries); return useKeyserverCall(fetchEntries);
} }
export type UpdateCalendarQueryInput = { export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean, +reduxAlreadyUpdated?: boolean,
+keyserverIDs?: $ReadOnlyArray<string>,
}; };
const updateCalendarQueryActionTypes = Object.freeze({ const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED', started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS', success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED', failed: 'UPDATE_CALENDAR_QUERY_FAILED',
}); });
const updateCalendarQuery = const updateCalendarQuery =
( (
callKeyserverEndpoint: CallKeyserverEndpoint, callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>, allKeyserverIDs: $ReadOnlyArray<string>,
): (( ): ((
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) => ) => Promise<CalendarQueryUpdateResult>) =>
async input => { async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input; const { calendarQuery, reduxAlreadyUpdated = false } = input;
const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;
const calendarQueries = sortCalendarQueryPerKeyserver( const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery, calendarQuery,
allKeyserverIDs, keyserverIDs,
); );
const requests: { [string]: CalendarQuery } = {}; const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) { for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID]; requests[keyserverID] = calendarQueries[keyserverID];
} }
const responses = await callKeyserverEndpoint( const responses = await callKeyserverEndpoint(
'update_calendar_query', 'update_calendar_query',
requests, requests,
); );
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = []; let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = []; let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) { for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat( rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos, responses[keyserverID].rawEntryInfos,
); );
deletedEntryIDs = deletedEntryIDs.concat( deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs, responses[keyserverID].deletedEntryIDs,
); );
} }
return { return {
rawEntryInfos, rawEntryInfos,
deletedEntryIDs, deletedEntryIDs,
calendarQuery, calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated, calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
keyserverIDs,
}; };
}; };
function useUpdateCalendarQuery(): ( function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> { ) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery); return useKeyserverCall(updateCalendarQuery);
} }
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

web/redux/persist.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunction useFetchEntries(): (
calendarQuery: CalendarQuery, calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> { ) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries); return useKeyserverCall(fetchEntries);
} }
export type UpdateCalendarQueryInput = { export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean, +reduxAlreadyUpdated?: boolean,
+keyserverIDs?: $ReadOnlyArray<string>,
}; };
const updateCalendarQueryActionTypes = Object.freeze({ const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED', started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS', success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED', failed: 'UPDATE_CALENDAR_QUERY_FAILED',
}); });
const updateCalendarQuery = const updateCalendarQuery =
( (
callKeyserverEndpoint: CallKeyserverEndpoint, callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>, allKeyserverIDs: $ReadOnlyArray<string>,
): (( ): ((
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) => ) => Promise<CalendarQueryUpdateResult>) =>
async input => { async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input; const { calendarQuery, reduxAlreadyUpdated = false } = input;
const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;
const calendarQueries = sortCalendarQueryPerKeyserver( const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery, calendarQuery,
allKeyserverIDs, keyserverIDs,
); );
const requests: { [string]: CalendarQuery } = {}; const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) { for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID]; requests[keyserverID] = calendarQueries[keyserverID];
} }
const responses = await callKeyserverEndpoint( const responses = await callKeyserverEndpoint(
'update_calendar_query', 'update_calendar_query',
requests, requests,
); );
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = []; let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = []; let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) { for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat( rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos, responses[keyserverID].rawEntryInfos,
); );
deletedEntryIDs = deletedEntryIDs.concat( deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs, responses[keyserverID].deletedEntryIDs,
); );
} }
return { return {
rawEntryInfos, rawEntryInfos,
deletedEntryIDs, deletedEntryIDs,
calendarQuery, calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated, calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
keyserverIDs,
}; };
}; };
function useUpdateCalendarQuery(): ( function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput, input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> { ) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery); return useKeyserverCall(updateCalendarQuery);
} }
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines