HomePhabricator
Diffusion Comm 1e4672088b22

[native] Avoid invariant crash in getDevNodeServerURL

Description

[native] Avoid invariant crash in getDevNodeServerURL

Summary:
D6269 updated release builds to hit getDevNodeServerURL, which is causing a crash. This is happening because the result of getDevNodeServerURL is included in the default list of server options in the Developer tools section of the app.

There's probably no risk to calling this in production, especially since we already call dev-hostname.js code from release builds in natNodeServer. It's better to improve readability of the code and remove this invariant than to sidestep it.

Test Plan: Confirm release build no longer crashes

Reviewers: bartek

Reviewed By: bartek

Subscribers: tomek, atul

Differential Revision: https://phab.comm.dev/D6332

Details

Provenance
ashoatAuthored on Jan 21 2023, 12:40 PM
Reviewer
bartek
Differential Revision
D6332: [native] Avoid invariant crash in getDevNodeServerURL
Parents
rCOMMd1c586944e3a: Bump jsonwebtoken from 8.5.1 to 9.0.0
Branches
Unknown
Tags
Unknown