HomePhabricator
Diffusion Comm 21e960b9d732

[Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.

Description

[Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.js

Summary:
This one ended up being much more involved that I initially hoped. The main changes here are:

  1. Probably reflect that the id field should only be required on the client. It should be optional on the keyserver, which needs to continue supporting older clients.
  2. Update the validators to only consider fields included by supported client versions.
NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9862

Test Plan: Confirm the Flow errors go away

Reviewers: bartek, kamil

Reviewed By: kamil

Subscribers: kamil, tomek

Differential Revision: https://phab.comm.dev/D9863