Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [13/x] Address type errors with cookie-parser libdef
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 6:19 PM
Unknown Object (File)
Sun, Oct 27, 8:54 PM
Unknown Object (File)
Sep 29 2024, 3:22 AM
Unknown Object (File)
Sep 29 2024, 3:22 AM
Unknown Object (File)
Sep 29 2024, 3:21 AM
Unknown Object (File)
Sep 29 2024, 3:10 AM
Unknown Object (File)
Aug 28 2024, 7:24 AM
Unknown Object (File)
Aug 28 2024, 7:16 AM
Subscribers
None

Details

Summary

The cookie-parser libdef contains definitions that are copy-pasted from the express libdef. This is because older versions of flow-typed did not support importing types from another libdef.

The new version of Flow doesn't like this, as it's not able to conclude that the copy-pasted types are the same as the original types, even if I update them to match.

Instead, I've reimplemented the cookie-parser libdef without any copy-paste, and using imports instead.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9861

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:27 PM
Harbormaster failed remote builds in B24079: Diff 33178!
This revision is now accepted and ready to land.Nov 14 2023, 8:45 AM
ashoat retitled this revision from [Flow202][keyserver] [13/x] Address type errors with cookie-parser libdef to [Flow202][keyserver][skip-ci] [13/x] Address type errors with cookie-parser libdef.Nov 19 2023, 5:07 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM
This revision was automatically updated to reflect the committed changes.