Page MenuHomePhabricator

[Flow202][lib][skip-ci] [10/23] Fix Flow issues with untyped let declarations in entry-reducer
ClosedPublic

Authored by ashoat on Nov 4 2023, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:15 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:33 PM
Unknown Object (File)
Sep 29 2024, 2:44 AM
Unknown Object (File)
Sep 29 2024, 2:11 AM
Unknown Object (File)
Sep 9 2024, 9:11 AM
Unknown Object (File)
Sep 6 2024, 6:48 PM
Subscribers

Details

Summary

The new version of Flow wants annotations on let expressions that cover later assignments.

Normally this just means adding an annotation, but in this case it's complicated because updatedEntryInfos is first treated as mutable and later as immutable.

To address this, I separated that variable out into two, allowing them to be typed differently.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9701

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:21 PM
Harbormaster failed remote builds in B23744: Diff 32706!
This revision is now accepted and ready to land.Nov 5 2023, 10:48 AM
ashoat retitled this revision from [Flow202][lib] [10/23] Fix Flow issues with untyped let declarations in entry-reducer to [Flow202][lib][skip-ci] [10/23] Fix Flow issues with untyped let declarations in entry-reducer.Nov 19 2023, 11:47 AM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.