Page MenuHomePhabricator

[Flow202][native][skip-ci] [35/x] Add memo for appliedStyles in EditSettingButton
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:17 AM.
Tags
None
Referenced Files
F3366956: D10019.id33902.diff
Mon, Nov 25, 1:10 PM
Unknown Object (File)
Fri, Nov 8, 6:46 AM
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Oct 19 2024, 11:12 PM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Subscribers

Details

Summary

The new version of Flow asked me to type appliedStyles. While doing that I noticed that this array was not memoized. Decided to separate this out since it has more substantial changes.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10018

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable