Differential D9986 Authored by ashoat on Nov 27 2023, 12:25 AM.
Details Summary This simple change eliminated 749 errors, which is 23.2% of all of errors I'm seeing in native. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9985 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptNov 27 2023, 12:25 AM2023-11-27 00:25:33 (UTC-8) Harbormaster completed remote builds in B24427: Diff 33630.Nov 27 2023, 12:25 AM2023-11-27 00:25:37 (UTC-8) This revision is now accepted and ready to land.Nov 27 2023, 1:40 AM2023-11-27 01:40:32 (UTC-8) Closed by commit rCOMM510ab126cea9: [Flow202][native][skip-ci] [2/x] Type all MediaMissionStep arrays (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM2023-11-27 15:27:35 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33869 |