Page MenuHomePhabricator

[Flow202][native][skip-ci] [57/x] Avoid looking up nullable type in non-nullable Set in ChatRouter
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:18 AM
Unknown Object (File)
Feb 4 2024, 11:54 AM
Unknown Object (File)
Dec 20 2023, 3:05 PM
Unknown Object (File)
Dec 17 2023, 6:39 AM
Unknown Object (File)
Dec 16 2023, 9:17 PM
Subscribers
None

Details

Summary

Flow doesn't like that we're calling Set<string>.has with a ?string. To avoid this, I check the type before calling has() here.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10040

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable