Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [15/x] Fix Flow issues with types being underconstrained
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 8:54 PM
Unknown Object (File)
Oct 20 2024, 8:43 PM
Unknown Object (File)
Oct 14 2024, 9:11 PM
Unknown Object (File)
Oct 14 2024, 9:08 PM
Unknown Object (File)
Oct 14 2024, 8:05 PM
Unknown Object (File)
Oct 14 2024, 7:08 PM
Unknown Object (File)
Oct 13 2024, 3:38 AM
Unknown Object (File)
Sep 29 2024, 3:22 AM
Subscribers

Details

Summary

The new version of Flow is requiring declarations to provide explicit type params when Flow isn't able to infer them. This diff adds those declarations in most cases that aren't specific enough to be covered in another diff.

This is the keyserver equivalent of D9695 (lib) and D9775 (web).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9863

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:30 PM
Harbormaster failed remote builds in B24081: Diff 33180!
This revision is now accepted and ready to land.Nov 14 2023, 12:44 PM
ashoat retitled this revision from [Flow202][keyserver] [15/x] Fix Flow issues with types being underconstrained to [Flow202][keyserver][skip-ci] [15/x] Fix Flow issues with types being underconstrained.Nov 19 2023, 5:07 PM