Page MenuHomePhabricator

[Flow202][native][skip-ci] [55/x] Fix Flow issues by adding Promise types
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 8 2024, 10:27 PM
Unknown Object (File)
Sep 6 2024, 1:47 AM
Unknown Object (File)
Sep 6 2024, 1:47 AM
Subscribers
None

Details

Summary

The new version of Flow seems to want all new Promise instantiations to be parameterized with the promise's type. It also wants some more typehints in places where it can't deduce the correct type param for Promise.

This is the native equivalent of D9779 (web) and D9711 (lib).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10038

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable